Parse OPERATOR as Vec<String>#1
Merged
iskakaushik merged 1 commit intoiskakaushik:postgres-custom-operatorfrom Aug 5, 2022
Merged
Parse OPERATOR as Vec<String>#1iskakaushik merged 1 commit intoiskakaushik:postgres-custom-operatorfrom
OPERATOR as Vec<String>#1iskakaushik merged 1 commit intoiskakaushik:postgres-custom-operatorfrom
Conversation
alamb
commented
Aug 5, 2022
| /// | ||
| /// See [CREATE OPERATOR](https://www.postgresql.org/docs/current/sql-createoperator.html) | ||
| /// for more information. | ||
| PGCustomBinaryOperator(Vec<String>), |
Author
There was a problem hiding this comment.
One downside of this approach that I can think of is that it does not restrict the initial parts of the custom operator to valid tokens
Aka this should probably really be something like
Suggested change
| PGCustomBinaryOperator(Vec<String>), | |
| PGCustomBinaryOperator{ ident: Vec<Ident>, op: String), |
But I think this may be good enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re https://github.com/sqlparser-rs/sqlparser-rs/pull/548/files
Here is a proposed alternative (targeting your branch) that represents a PG custom operator using
Vec<String>of the raw token streams and demonstrating it is more general