-
Notifications
You must be signed in to change notification settings - Fork 259
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: isaacs/node-tar
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4aaffc8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: isaacs/node-tar
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bef7b1e
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 16 commits
- 33 files changed
- 2 contributors
Commits on May 12, 2023
-
move mutateFS reset out of t.teardown
Not sure why this was failing on my system, but this fixes it.
Configuration menu - View commit details
-
Copy full SHA for 8cd8139 - Browse repository at this point
Copy the full SHA 8cd8139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24efc74 - Browse repository at this point
Copy the full SHA 24efc74View commit details
Commits on May 17, 2023
-
Normalize unicode internally using NFD
Previously, the path reservation system, which defends against unicode path name collisions (the subject of a handful of past CVE issues), was using NFKD normalization internally to determine of two paths would be likely to reference the same file on disk. This has the weird effect of normalizing things like `℀` into simple decomposed character strings, for example `a/c`. These can contain slashes and double-dot sections, which means that the path reservations may end up reserving more (or different) paths than intended. Thankfully, tar was already *extracting* properly, even if the path reservations collided, and these collisions resulted in tar being *more* aggressive than it should be in restricting parallel extraction, rather than less. That's a good direction to err in, for security, but also, made tar less efficient than it could be in some edge cases. Using NFD normalization, unicode characters are not decomposed in compatibility mode, but still result in matching path reservation keys as intended. This does not cause any change in observed behavior, other than allowing some files to be extracted in parallel where it is provably safe to do so. Credit: discovered by @Sim4n6. This did not result in a juicy security vulnerability, but it sure looked like one at first. They were extremely patient, thorough, and persistent in trying to pin this down to a POC and CVE. There is very little reward or visibility when a security researcher finds a bug that doesn't result in a security disclosure, but the attempt often results in improvements to the project.
Configuration menu - View commit details
-
Copy full SHA for 4501bdb - Browse repository at this point
Copy the full SHA 4501bdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3302cf7 - Browse repository at this point
Copy the full SHA 3302cf7View commit details
Commits on May 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8c5af15 - Browse repository at this point
Copy the full SHA 8c5af15View commit details
Commits on Jun 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c9fc57c - Browse repository at this point
Copy the full SHA c9fc57cView commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eeba222 - Browse repository at this point
Copy the full SHA eeba222View commit details
Commits on Sep 5, 2023
-
refactor: dry and other pr comments
PR-URL: #391 Credit: @JamieMagee Close: #391 Reviewed-by: @isaacs
Configuration menu - View commit details
-
Copy full SHA for 336fa8f - Browse repository at this point
Copy the full SHA 336fa8fView commit details -
file inference improvements for .tbr and .tgz
When unpacking, only infer brotli compression from the filename if the first 512 bytes are an invalid tar header (or the stream is less than 512 bytes) While Brotli doesn't give us magic header bytes like gzip, we can be reasonably sure that a .tbr file starting with 512 bytes of valid tar data is almost certainly not a brotli compressed archive. And a .tbr file starting with the magic gzip bytes is almost certainly a gzip archive, and not brotli, despite what the filename says. In all cases, if explicit boolean or object values appear in the options for either gzip or brotli, we respect that, and ignore the filename.
Configuration menu - View commit details
-
Copy full SHA for db6f539 - Browse repository at this point
Copy the full SHA db6f539View commit details -
Configuration menu - View commit details
-
Copy full SHA for 689928a - Browse repository at this point
Copy the full SHA 689928aView commit details -
Will replace with prettier at some point, but for now, whatever.
Configuration menu - View commit details
-
Copy full SHA for e483220 - Browse repository at this point
Copy the full SHA e483220View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe1ef5e - Browse repository at this point
Copy the full SHA fe1ef5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bc9d40 - Browse repository at this point
Copy the full SHA 5bc9d40View commit details
Commits on Feb 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe7ebfd - Browse repository at this point
Copy the full SHA fe7ebfdView commit details
Commits on Mar 21, 2024
-
prevent extraction in excessively deep subfolders
This sets the limit at 1024 subfolders nesting by default, but that can be dropped down, or set to Infinity to remove the limitation.
Configuration menu - View commit details
-
Copy full SHA for fe8cd57 - Browse repository at this point
Copy the full SHA fe8cd57View commit details -
Configuration menu - View commit details
-
Copy full SHA for bef7b1e - Browse repository at this point
Copy the full SHA bef7b1eView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4aaffc8...bef7b1e