Ensure process object exists for deprecation warn#207
Merged
isaacs merged 1 commit intoisaacs:mainfrom Mar 9, 2022
tavogel:patch-1
Merged
Ensure process object exists for deprecation warn#207isaacs merged 1 commit intoisaacs:mainfrom tavogel:patch-1
isaacs merged 1 commit intoisaacs:mainfrom
tavogel:patch-1
Conversation
isaacs
reviewed
Mar 8, 2022
Owner
|
Looks good, just needs a test. You can take a look at one of the deprecation tests, and just add something like: t.test('does not do deprecation warning without process object', t => {
const proc = process
t.teardown(() => global.process = proc)
global.process = null
// do something that triggers a deprecation, ensure nothing was logged
t.end()
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #206