Fix copyFile wrapper when retry() hits EMFILE again#209
Merged
isaacs merged 1 commit intoisaacs:masterfrom Jul 20, 2021
Merged
Conversation
Author
|
I don't understand the CI failures. The EDIT: Ah, I see it's not an abnormal situation. 😌 |
PR-URL: isaacs#209 Credit: @mbargiel Close: isaacs#209 Reviewed-by: @isaacs
isaacs
force-pushed
the
feature/fix-copyfile-enqueue
branch
from
51913d5 to
16f8da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
copyFilewrapper introduced in #199 does not follow the same pattern as the other wrappers, and enqueued the wrappedcopyFilerather than the wrapper function, which means that a subsequentEMFILEorENFILEerror occurring when retrying thecopyFilewould fail and bubble theEMFILEorENFILEto the calling code rather than enqueue again. This fix applies the same pattern by introducinggo$copyFileand enqueueing it rather thanfs$copyFile.Fixes #208.
All tests pass and coverage goes up a bit (probably just because the new lines of test code are covered). I couldn't find tests that validate the
EMFILEretry logic for thefsfunction wrappers (at least not forcopyFile).