fix partial matching of globstar patterns

isaacs · isaacs · commit 71b78a2a4cad · 2026-02-25T09:02:13.000-08:00
Fix: #284 Backport of 3a0d83b to v9
diff --git a/src/index.ts b/src/index.ts
@@ -835,7 +835,11 @@ export class Minimatch {
     const firstgs = pattern.indexOf(GLOBSTAR, patternIndex)
     const lastgs = pattern.lastIndexOf(GLOBSTAR)
 
-    const [head, body, tail] = [
+    const [head, body, tail] = partial ? [
+      pattern.slice(patternIndex, firstgs),
+      pattern.slice(firstgs + 1),
+      [],
+    ] : [
       pattern.slice(patternIndex, firstgs),
       pattern.slice(firstgs + 1, lastgs),
       pattern.slice(lastgs + 1),
@@ -878,7 +882,7 @@ export class Minimatch {
           return false
         }
       }
-      return sawSome
+      return partial || sawSome
     }
 
     const bodySegments: [ParseReturn[], number][] = [[[], 0]]
@@ -952,7 +956,7 @@ export class Minimatch {
       }
       fileIndex++
     }
-    return null
+    return partial || null
   }
 
   #matchOne(
diff --git a/test/partial.js b/test/partial.js
@@ -1,7 +1,16 @@
 import t from 'tap'
 import { minimatch as mm } from '../dist/esm/index.js'
+
 t.equal(mm('/a/b', '/*/b/x/y/z', { partial: true }), true)
 t.equal(mm('/a/b/c', '/*/b/x/y/z', { partial: true }), false)
 t.equal(mm('/', 'x', { partial: true }), true)
 const m = new mm.Minimatch('/*/b/x/y/z')
 t.equal(m.match('/a/b', true), true)
+t.equal(mm('/b/c/d/a', '/**/a/b/c', { partial: true }), true)
+t.equal(mm('/b/c/d/a', '/**/a/b/c/**', { partial: true }), true)
+
+t.equal(mm('a', 'a/**', { partial: true }), true)
+t.equal(mm('a', '**', { partial: true }), true)
+t.equal(mm('b/a', 'a/**', { partial: true }), false)
+t.equal(mm('/b/c/d/a', '/**/a/**/b/c/**', { partial: true }), true)
+t.equal(mm('/b/c/d/a', '/**/a/**', { partial: true }), true)

Original file line number	Diff line number	Diff line change
`@@ -835,7 +835,11 @@ export class Minimatch {`
`835`	`835`	`const firstgs = pattern.indexOf(GLOBSTAR, patternIndex)`
`836`	`836`	`const lastgs = pattern.lastIndexOf(GLOBSTAR)`
`837`	`837`
`838`		`- const [head, body, tail] = [`
	`838`	`+ const [head, body, tail] = partial ? [`
	`839`	`+ pattern.slice(patternIndex, firstgs),`
	`840`	`+ pattern.slice(firstgs + 1),`
	`841`	`+ [],`
	`842`	`+ ] : [`
`839`	`843`	`pattern.slice(patternIndex, firstgs),`
`840`	`844`	`pattern.slice(firstgs + 1, lastgs),`
`841`	`845`	`pattern.slice(lastgs + 1),`
`@@ -878,7 +882,7 @@ export class Minimatch {`
`878`	`882`	`return false`
`879`	`883`	`}`
`880`	`884`	`}`
`881`		`- return sawSome`
	`885`	`+ return partial \|\| sawSome`
`882`	`886`	`}`
`883`	`887`
`884`	`888`	`const bodySegments: [ParseReturn[], number][] = [[[], 0]]`
`@@ -952,7 +956,7 @@ export class Minimatch {`
`952`	`956`	`}`
`953`	`957`	`fileIndex++`
`954`	`958`	`}`
`955`		`- return null`
	`959`	`+ return partial \|\| null`
`956`	`960`	`}`
`957`	`961`
`958`	`962`	`#matchOne(`