Repository navigation
Commit ec9dbb2
A second close of a connection does nothing; the driver tests follow where native is refused
- The seam's connection count called the driver's close() before checking
whether that connection was already closed. node:sqlite throws on a second
close ("database is not open"); better-sqlite3 does not. The file is still
let go only after a close that succeeded. A driver test now closes a
built-in connection twice on every cell that has the built-in driver.
- The job that builds the addon from source refuses native on Node 24
(nodejs/node#65446). There the worker test asserts that refusal and runs the
drivers that open, and the connection-count test skips reopening the file
with a copy that cannot load.
- The two-copies CI step splits each pair explicitly and quotes both halves
(shellcheck SC2086).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>1 parent 24a96e7 commit ec9dbb2
3 files changed
Lines changed: 15 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
328 | | - | |
| 328 | + | |
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
538 | 538 | | |
539 | 539 | | |
540 | 540 | | |
| 541 | + | |
541 | 542 | | |
542 | | - | |
543 | 543 | | |
| 544 | + | |
544 | 545 | | |
545 | 546 | | |
546 | 547 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
491 | 491 | | |
492 | 492 | | |
493 | 493 | | |
494 | | - | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
495 | 502 | | |
496 | 503 | | |
497 | 504 | | |
498 | 505 | | |
499 | 506 | | |
500 | 507 | | |
501 | 508 | | |
502 | | - | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
503 | 513 | | |
504 | 514 | | |
505 | 515 | | |
| |||
0 commit comments