Repository navigation
ipython-directive improvements - #8888
Merged
Merged
Conversation
by default, instead of the input directory
Contributor
|
This branch fixes my minimal test case from #8850. |
Contributor
|
In case it's interesting - matplotlib has a test rig for testing the plot_directive : https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/sphinxext/tests/test_tinypages.py |
Member
|
+1 with that. Should we open an issue to bring the mpl test case in here, or is that better in MPL ? |
Contributor
|
I refactored those tests in a small extension package. That version might be more portable to the IPython test machinery? |
2 tasks
Member
|
Shoudl we merge and iterate on it later if needed ? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipython_directive@savefig: should detect missing static html dir and not place output in source dir #8733)OperationalError: attempt to write a readonly database#8850)