Repository navigation
Revert "Prevent image outputs from being wider than their container." - #7818
Merged
Merged
Conversation
Member
|
Given the various options:
I'm slightly inclined to keep the 2.x behavior, even though it makes it easy to produce slightly ugly output. If there were an easy way to express "don't confine to width", then I might be inclined to keep #7721, assuming a simple fix for the aspect ratio is found. Given that #7721 as-is doesn't quite work, and causes problems when larger images are desirable, I think we should go with this PR for 3.0. We can try to get a better version of #7721 with fixed aspect ratio and that allows explicit disabling of the shrink-to-fit behavior for 3.1. |
jdfreder
added a commit
that referenced
this pull request
Feb 20, 2015
Revert "Prevent image outputs from being wider than their container."
Contributor
|
Thanks for opening this @takluyver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7721 (see discussion on that PR)
Reopens #7701
Ping @jdfreder