Merged
Conversation
Thoses that are obvious and easy to fix. we shoudl have I think a travis test that grep for .html( and return less than 20 lines :-)
Member
Author
|
@ivanov, you are the King on casper test. Is this the right way ? |
Member
Author
|
:-( test are supposed to fail for once. but they don't. |
Member
|
sent you a PR to make them fail, Matthias (just a minor typo) 🍻 |
make the JS test fail
Member
Author
|
Travis should be angry soon, then I fix the injection in prompt :-) |
Member
|
Looks, good, anything else before merging? |
ghost
assigned
Member
Author
|
No, I'll do more step by step in small PR when I get time. Unlike you I'm not used to have more than 5 PR in parallel :-) |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
some $.html( -> $.text(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoses that are obvious and easy to fix.
we shoudl have I think a travis test that grep for .html( and return
less than 20 lines :-)
One more fix is
html('×')tohtml('×')(add semicolon).Havent check manually each place in UI.