don't set target on internal markdown links#3824
Merged
minrk merged 1 commit intoipython:masterfrom Jul 29, 2013
Merged
Conversation
simple in-page anchor-nav shouldn't open a new tab.
Member
|
+1 |
minrk
added a commit
that referenced
this pull request
Jul 29, 2013
don't set target on internal markdown links simple in-page anchor navs shouldn't open a new tab.
|
i just pulled the master, but it doesnt appear to change the behaviour (new tabs are still opened) |
Member
Author
|
Refresh the page to make sure the js is updated in the cache |
|
works. thanks! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
don't set target on internal markdown links simple in-page anchor navs shouldn't open a new tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple in-page anchor-nav shouldn't open a new tab.