Merged
Conversation
- use id instead of name - replace spaces with `_` for html compliance
avoids blue links after visiting
Member
|
+1. Do you want to add an encodeURI to be safe ? I agree That _ is more readable than %20. |
Member
Author
|
I looked into it, and anchors do not have the same restrictions as URIs - no spaces is the only requirement. That's why I went with underscore instead of encodeURI. |
Member
Merging then. Thanks ! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
minor heading-link tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_for html compliance
and tweak heading-anchor css to avoid blue visited links.