IPython.utils._process_posix: import pexpect only when needed#14312
Merged
Carreau merged 1 commit intoipython:mainfrom Jan 31, 2024
Merged
IPython.utils._process_posix: import pexpect only when needed#14312Carreau merged 1 commit intoipython:mainfrom
IPython.utils._process_posix: import pexpect only when needed#14312Carreau merged 1 commit intoipython:mainfrom
Conversation
2 tasks
Contributor
|
I'd suggest adding a new file making a def system(cmd):
raise OSError("Not available")
def getoutput(cmd):
raise OSError("Not available")
def check_pid(cmd):
raise OSError("Not available")
def arg_split(s, posix=False, strict=True):
"""This one could be made to work but it's not clear if it would be useful..."""
raise OSError("Not available")and then apply this patch: --- a/IPython/utils/process.py
+++ b/IPython/utils/process.py
@@ -15,6 +15,8 @@
from ._process_win32 import system, getoutput, arg_split, check_pid
elif sys.platform == 'cli':
from ._process_cli import system, getoutput, arg_split, check_pid
+elif sys.platform == "emscripten":
+ from ._process_emscripten import system, getoutput, arg_split, check_pid
else:
from ._process_posix import system, getoutput, arg_split, check_pid |
Member
|
I'm going to make a release soon, so I'm going to merge this, but +1 to extend with adding a |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delaying the import of
pexpectto the first use.This is needed to make
import IPythonwork on Pyodide; see pyodide/pyodide#4452