fall back to native when printing an ExceptionGroup #14108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
force-pushed
the
fallback_display_exceptiongroup
branch
from
06e2175 to
46e4d49
Compare
jakkdl
force-pushed
the
fallback_display_exceptiongroup
branch
from
46e4d49 to
92b86a7
Compare
Contributor
Author
|
I have no idea why the @Carreau would you mind reviewing? |
Member
|
Apologies for the delay in reviewing I don't have much time on IPython. Don't worry about the downstream failure. |
Contributor
Author
|
No worries! I noticed you said the same in the other PRs so realized I should just go full steam ahead and implement the full PR so you only needed a single review pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13753
I started looking into delving deeper into ultratb to add support for Exception Groups, but felt that this would be enough of an improvement over the status quo that it'd probably be worth implementing on it's own.
I also looked quite a bit at ipyparallel's
CompositeErrorhttps://github.com/ipython/ipyparallel/blob/main/ipyparallel/error.py#L169, which seems like the equivalent of exception groups.Remaining TODO:
Will go ahead with those if the basic approach is deemed acceptable