Repository navigation
Shaperilio/qtgui fixes - #13957
Merged
Merged
Shaperilio/qtgui fixes#13957
Conversation
If the requested Qt version can't be loaded.
People can't switch Qt versions willy-nilly anyway.
The event loop will run anyway with the previously selected Qt version.
This reverts commit aa58888.
Contributor
Author
|
@Carreau @ccordoba12 FYI |
ccordoba12
reviewed
Mar 1, 2023
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
A couple of small suggestions for you @shaperilio, otherwise looks good to me.
Contributor
Author
Thanks; I committed your suggestions. |
ccordoba12
approved these changes
Mar 1, 2023
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
Looks good to me now, thanks @shaperilio!
Contributor
Author
|
@Carreau any comments? |
Member
|
I don't have much experience in this part of the codebase, things looks fine to me, and if both of you are happy with it let's go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started using the released version of my
PySide6-enabling changes and noted some problems. In this PR, I fix those, and also overall improve the feedback to the user when a GUI event loop is hooked in:%gui <some GUI>; e.g.%gui qtwill showInstalled qt6 event loop hook.%guiwill showGUI event loop hook disabled.if an event loop hook was installed, orNo event loop hook running.if nothing was installed.Shell is already running a gui event loop for <some GUI>. Call with no arguments to disable current loop.%gui qt6followed by%guifollowed by%gui qt5will showCannot switch Qt versions for this session; will use qt6.followed byInstalled qt6 event loop hook.(Fixes / improves #13864)