Skip to content

ENH: add support for Qt6 input hooks - #13085

Merged
Carreau merged 2 commits into
ipython:masterfrom
tacaswell:qt6
Aug 18, 2021
Merged

Carreau merged 2 commits into
ipython:masterfrom
tacaswell:qt6

Conversation

@tacaswell

Copy link
Copy Markdown
Contributor

This is heavily cribbed from Matplotlib's Qt6 support.

This is heavily cribbed from Matplotlib's Qt6 support.
@Carreau Carreau modified the milestones: 8.0, 7.27 Aug 18, 2021
@Carreau

Carreau commented Aug 18, 2021

Copy link
Copy Markdown
Member

Let's see if that backports cleanly to 7.x

@Carreau
Carreau merged commit f50981d into ipython:master Aug 18, 2021
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request Aug 18, 2021
@tacaswell
tacaswell deleted the qt6 branch August 18, 2021 19:43
Carreau added a commit that referenced this pull request Aug 18, 2021
…085-on-7.x

Backport PR #13085 on branch 7.x (ENH: add support for Qt6 input hooks)
@pijyoi

pijyoi commented Aug 29, 2021

Copy link
Copy Markdown
Contributor

Tried briefly 7.27 with Qt6 on Windows. It works with PySide6 but not PyQt6.

(allqt) PS C:\work> $env:QT_API="pyqt6"
(allqt) PS C:\work> ipython
Python 3.8.10 (tags/v3.8.10:3d8993a, May  3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.27.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: %gui qt

In [2]: Traceback (most recent call last):
# snip
  File "c:\work\venv\allqt\lib\site-packages\IPython\terminal\pt_inputhooks\qt.py", line 67, in inputhook
    event_loop.exec_()
AttributeError: 'QEventLoop' object has no attribute 'exec_'

@tacaswell

Copy link
Copy Markdown
Contributor Author

That is odd, I would have expected the traceback to be hitting around line 83 as

is the relevant line at the 7.27.0 tag.

@MrMino

MrMino commented Aug 31, 2021

Copy link
Copy Markdown
Member

I guess this is a bug? @pijyoi or @tacaswell could one of you please put it up as a new issue?

@pijyoi

pijyoi commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Ok, I have created issue #13116

@MrMino

MrMino commented Sep 1, 2021

Copy link
Copy Markdown
Member

@pijyoi thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants