Repository navigation
Merged
Conversation
Member
|
Thanks @ShailynOrtiz for the PR. We'll take a look and review this. cc/ @minrk @takluyver Submitted at the PyCaribbean sprint organized by @jzf2101 |
willingc
reviewed
Feb 18, 2018
willingc
left a comment
willingc
left a comment
Member
There was a problem hiding this comment.
Thanks @ShailynOrtiz. This looks good to me. Leaving for @takluyver or @minrk to merge.
minrk
reviewed
Feb 19, 2018
| completer=IPythonPTCompleter(shell=self, | ||
| patch_stdout=patch_stdout), | ||
| enable_history_search=True, | ||
| enable_history_search=( |
Member
There was a problem hiding this comment.
Thanks! Can you make this a Bool(True, config=True) trait rather than an environment variable? That's how we make things configurable in IPython. See highlight_matching_brackets above on L194 for a similar example (it has a default of False, but this should default to True). Then here it can be enable_history_search=self.enable_history_search.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #9961
make use of os.environ to read from an envvar called enable_history_search which must be true or false, and if it's not present the default is set to True as it was before.