search backwards by default #10075

Activity

1. takluyver commented on Dec 5, 2016

   

   takluyver

   on Dec 5, 2016

   Member

   More actions

   @jonathanslenders ? It might just be an oversight.

   You can customise the keyboard shortcuts as described here, but for now you'll need to search through prompt_toolkit source code to find what function it needs to call.
2. altaurog commented on Dec 5, 2016

   

   altaurog

   on Dec 5, 2016

   Author

   More actions

   Thanks. I see. That was what I needed to get me pointed in the right direction. Shall I move this issue to the prompt_toolkit repo?
3. takluyver commented on Dec 5, 2016

   

   takluyver

   on Dec 5, 2016

   Member

   More actions

   I don't think IPython defines any shortcuts specific to vim mode, so this is probably in prompt_toolkit. Jonathan often responds quickly when we ping him, though. So I'd suggest you give it a day or two, and if he doesn't say anything, re-file it on PT.
4. altaurog commented on Dec 5, 2016

   

   altaurog

   on Dec 5, 2016

   Author

   More actions

   This seems to do the trick. It retrieves the bound functions for '/' and '?' and switches them.

   from IPython import get_ipython
   from prompt_toolkit.filters import ViSelectionMode, ViNavigationMode, ViMode
   
   ip = get_ipython()
   mode = (ViNavigationMode() | ViSelectionMode()) & ViMode()
   
   if getattr(ip, 'pt_cli'):
       registry = ip.pt_cli.application.key_bindings_registry
       is_search = lambda b: b.filter == mode
       forward = filter(is_search, registry.get_bindings_for_keys('/'))
       backward = filter(is_search, registry.get_bindings_for_keys('?'))
       for b in backward:
           registry.remove_binding(b.handler)
           registry.add_binding('/', filter=mode, eager=b.eager,
                                save_before=b.save_before)(b.handler)
       for b in forward:
           registry.remove_binding(b.handler)
           registry.add_binding('?', filter=mode, eager=b.eager,
                                save_before=b.save_before)(b.handler)
   
5. jonathanslenders commented on Dec 5, 2016

   

   jonathanslenders

   on Dec 5, 2016

   Contributor

   More actions

   Hi @altaurog,

   For this, I copied the behaviour of Vi. The reason is that we support multiline editing. So, if you're at the start of a multiline buffer, then you could use forward search to jump forward. In a block of multiline text, you'll get more of the Vi feel, rather than a readline feeling.

   But maybe you're right. It could make sense to follow GNU readline, and use question mark to search forward.

   Could you open an issue in prompt_toolkit? Maybe I could make this easier to configure, or if I feel that everyone thinks it should be like readline, then I could reverse it.
6. ndronen commented on Dec 10, 2016

   

   ndronen

   on Dec 10, 2016

   More actions

   Multiline editing is a very nice feature. As a longtime vim and bash user, though, the switch to IPython 5.x and prompt_toolkit has been jarring. I would much prefer that vi-mode in prompt_toolkit behaved like it does in GNU readline.

   I've opened prompt-toolkit/python-prompt-toolkit#431 to move the discussion over there.
7. jonathanslenders commented on Dec 11, 2016

   

   jonathanslenders

   on Dec 11, 2016

   Contributor

   More actions

   @ndronen. I completely understand it. Thanks a lot for opening the issue!
8. takluyver

   added this to the no action milestone on Jan 12, 2017
9. takluyver commented on Jan 12, 2017

   

   takluyver

   on Jan 12, 2017

   Member

   More actions

   I see that this has been changed in prompt_toolkit, so when PT 1.0.10 or greater is released, it should be fixed in IPython without needing any change from us.
10. takluyver

    closed this as completedon Jan 12, 2017
11. ivanov commented on May 17, 2017

    

    ivanov

    on May 17, 2017

    Member

    More actions

    I just want to mention that if you would like the old (IPython <= 4.x) readline interface, it is now available separately as rlipython.

    pip install rlipython
    python -c "import rlipython as r; r.install()"
    

    Right now, it only works in IPython 6.0 (Python 3), but it will also work in Python 2 with the next IPython 5 release (5.4).