Merged
Conversation
handy method to wait for a number of engines to be ready
sahil1105
approved these changes
Jun 9, 2021
Collaborator
sahil1105
left a comment
sahil1105
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks!
Contributor
|
That's a nice solution Min! 😄 |
Member
Author
|
Thanks! I've used this so many times, including in the tests themselves and multiple demos, it was a bit silly for it not to be a method already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handy method to wait for a number of engines to be ready
While this doesn't implement the proposed approach in #241, this implements what I think is the right way to wait for engines to be registered.
closes #241