Avoid overriding Thread._context in Python 3.14 #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
avoid-override-thread-context
branch
from
c035a4d to
1ff11b6
Compare
Collaborator
Author
|
This is mostly working now. The failures look the same as on the |
Collaborator
Author
|
Evidence that this works locally for me using python 3.14: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot set
threading.Thread._contextin Python 3.14 as it is used for a newcontextargument passed to the constructor. Hence here changing use ofShellChannelThread._contexttoShellChannelThread._zmq_contextinstead.Fixes #1445.