Tests: Add robust tests for silent flag in subshells #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
approved these changes
Aug 13, 2025
Collaborator
ianthomas23
left a comment
ianthomas23
left a comment
There was a problem hiding this comment.
Thanks @pankaj-bind, this looks good to me.
There is just one linter complaint to fix, then I'd be happy to merge it.
This PR adds comprehensive tests for the `silent` flag in `execute_request`, focusing on subshell and concurrent execution scenarios. This improves test coverage and prevents regressions in output handling.
ianthomas23
force-pushed
the
add-tests-in-test_subshells
branch
from
af00ab5 to
f86a535
Compare
Collaborator
|
I've rebased on |
Collaborator
|
Thanks @pankaj-bind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ianthomas23, I have closed PR #1407 and replaced it with this new one.
This pull request adds comprehensive tests for the
silentflag inexecute_request, with a focus on subshell and concurrent execution scenarios. These changes improve test coverage and will help prevent regressions in output handling.