Correct use of asyncio.Lock to process a single control message at a time #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
6.x-control-lock
branch
from
3454119 to
4e1aed7
Compare
ianthomas23
added a commit
to ianthomas23/ipykernel
that referenced
this pull request
Aug 4, 2025
…e control message at a time (ipython#1416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the 6.30.0 release that sometimes allowed control messages to be processed concurrently instead of sequentially, causing failures in the use of the debugger for example. The fix is to reuse a single
asyncio.Lockto limit callingprocess_controlin a single async task at a time.There is a new test added as this scenario was not previously tested in CI.
Fixes #1412 and jupyterlab/jupyterlab#17739.