Replace @flaky.flaky decorate with pytest fixture
#1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `@pytest.mark.flaky` fixture in place of the `@flaky.flaky` decorator, to modernize the code and improve compatibility with other plugins providing the feature such as `pytest-rerunfailures`. Fixes ipython#1410 Signed-off-by: Michał Górny <[email protected]>
Contributor
Author
|
Could we also backport it to 6.x, please? |
ianthomas23
pushed a commit
that referenced
this pull request
Aug 7, 2025
Signed-off-by: Michał Górny <[email protected]>
Collaborator
Done in #1421. Sorry I missed it for this week's release. |
Contributor
Author
|
No problem at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
@pytest.mark.flakyfixture in place of the@flaky.flakydecorator, to modernize the code and improve compatibility with other plugins providing the feature such aspytest-rerunfailures.Fixes #1410