[Bugfix] Set shell idle when message skipped by "should_handle" in "dispatch_shell" #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
reviewed
May 15, 2025
Member
|
CC @ianthomas23 for review, hopefully this is pretty easy and straightforward. |
…l into execution-fix-boyuan
ianthomas23
approved these changes
May 16, 2025
Collaborator
ianthomas23
left a comment
ianthomas23
left a comment
There was a problem hiding this comment.
Thanks @dby-tmwctw, this looks sensible to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current "dispatch_shell", if we fail the "should_handle" check during execution, we will not send any message to ioPub indicating shell status. For a client waiting for an "idle" status update, this could block the state machine and cause a hang command. This PR fixes the bug by publishing an "idle" status when the "should_handle" check fails.