Skip to content

Make kernelbase._eventloop_set event thread-safe #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidbrochart merged 3 commits into from
Feb 27, 2025
Merged

Make kernelbase._eventloop_set event thread-safe #1366

davidbrochart merged 3 commits into from
Feb 27, 2025

Conversation

@davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Feb 27, 2025

See #1364.

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Feb 27, 2025

I can see locally that test_kernelapp.py::test_start_app passes with this PR if run independently, but it fails if the whole test suit is run.

@davidbrochart davidbrochart merged commit 7a18189 into ipython:main Feb 27, 2025
38 of 42 checks passed
@davidbrochart davidbrochart deleted the kernel-eventloop_set branch February 27, 2025 09:42
@davidbrochart davidbrochart mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidbrochart