Skip to content

Fix expected text depending on IPython version. #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Carreau merged 2 commits into from
Feb 24, 2025
Merged

Fix expected text depending on IPython version. #1354

Carreau merged 2 commits into from
Feb 24, 2025

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 23, 2025 •
edited
Loading

@Carreau Carreau requested a review from krassowski February 23, 2025 15:02
@krassowski
Copy link
Member

krassowski commented Feb 23, 2025

The test failures appear related:

FAILED tests/test_start_kernel.py::test_ipython_start_kernel_userns - assert 'DummyModule' in "\x1b[0;31mType:\x1b[0m        DummyMod\n\x1b[0;31mString form:\x1b[0m <IPython.core.interactiveshell.DummyMod object at 0x7ffa5510af10>\n\x1b[0;31mFile:\x1b[0m        ~/.local/share/hatch/env/virtual/ipykernel/_P2Rok5v/cov.qt5/lib/python3.9/site-packages/IPython/core/interactiveshell.py\n\x1b[0;31mDocstring:\x1b[0m  \nA dummy module used for IPython's interactive module when\na namespace must be assigned to the module's __dict__."

Carreau
Carreau commented Feb 24, 2025
View reviewed changes
@Carreau
Copy link
Member Author

Carreau commented Feb 24, 2025

Yeah, it's DummyMod instead of DummyModule

krassowski
krassowski approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Carreau Carreau added this to the 7.0 milestone Feb 24, 2025
@Carreau Carreau merged commit 4854752 into ipython:main Feb 24, 2025
29 of 30 checks passed
ianthomas23 pushed a commit to ianthomas23/ipykernel that referenced this pull request Apr 10, 2025
@Carreau @ianthomas23
Fix expected text depending on IPython version. (ipython#1354)
2ecbe4d
@ianthomas23 ianthomas23 mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krassowski krassowski krassowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Carreau @krassowski