Remove deprecated modules since 4.3 (2016). #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is annoying as this makes downstream tests fail in IPython, while the culprit is ipyparallel. Ipyparallel itself is tested, and main has been fixed, so we just get a false failure in IPython downstream tests. It's also been deprecated for 10 years, now, so at least we can have that removed from main; so that we can see if downstream breaks.
davidbrochart
approved these changes
Feb 20, 2025
Merged
krassowski
reviewed
Feb 26, 2025
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
Yup, if this break a lot of downstreams it is easy to revert as this just removed whole files.
Should we increase
ipykernel/.github/workflows/ci.yml
Line 80 in dd07f52
Since we are removing some files which did not have test coverage?
Member
|
Huh, it looks like coverage reporting is broken. I opened #1365, I guess this is good to merge then. |
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is annoying as this makes downstream tests fail in IPython, while the culprit is ipyparallel.
Ipyparallel itself is tested, and main has been fixed, so we just get a false failure in IPython downstream tests.
It's also been deprecated for 10 years, now, so at least we can have that removed from main; so that we can see if downstream breaks.