Remove test_check job #1335
Merged
Remove test_check job #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as ipython#1318, there is no reasons for it to be there anymore, and it is more annoying than anything else. It used to be usefull if you wanted to enforce some CI items but not other, but this is now native via branch protection rules, but now Github UI shows which jobs are required to pass for a PR to be merged, and with this it does not.
Carreau
force-pushed
the
no-test-check
branch
from
63cb5fb to
8c53db5
Compare
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1318, there is no reasons for it to be there anymore, and it is more annoying than anything else. It used to be usefull if you wanted to enforce some CI items but not other, but this is now native via branch protection rules, but now Github UI shows which jobs are required to pass for a PR to be merged, and with this it does not.