Remove downstream_check #1318
Merged
Remove downstream_check #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It says its for branch protection, but branch protection can already requires multiple checks, and it creates an arbitry extra failure, which is anyway ignored as downasrteam is failing on main. So it's just extra noise IMHO.
Member
Author
|
Actually I'm going to a say that IMHO using downstream check is even worse that using via protected banches, as now you have no direct visibility from the PR to which check are required and which hare not: You now get an arbitrary indirection, a link you must click, and scroll through to see what is actually needed... |
Member
|
👍 I removed the downstream_check branch protection rule |
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Feb 17, 2025
Same as ipython#1318, there is no reasons for it to be there anymore, and it is more annoying than anything else. It used to be usefull if you wanted to enforce some CI items but not other, but this is now native via branch protection rules, but now Github UI shows which jobs are required to pass for a PR to be merged, and with this it does not.
Merged
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Feb 17, 2025
Same as ipython#1318, there is no reasons for it to be there anymore, and it is more annoying than anything else. It used to be usefull if you wanted to enforce some CI items but not other, but this is now native via branch protection rules, but now Github UI shows which jobs are required to pass for a PR to be merged, and with this it does not.
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Jul 14, 2025
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Jul 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It says its for branch protection, but branch protection can already requires multiple checks, and it creates an arbitry extra failure, which is anyway ignored as downasrteam is failing on main.
So it's just extra noise IMHO.