Remove implicit bind_kernel in %qtconsole
#1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is wrong (is ipyparallel imported, not is this an ipython parallel engine) that should be the responsibility of ipython parallel to add this step
davidbrochart
approved these changes
Feb 4, 2025
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is wrong ("is ipyparallel imported", not "is this an ipython parallel engine"), leading to errors when called from a regular kernel (closes ipython/ipyparallel#922)
it should be the responsibility of ipython parallel to add this behavior, if desired