Use supported_features=['debugger'] in kernel info reply #1296
Conversation
ianthomas23
force-pushed
the
kernel-info-supported-debugger
branch
from
71217b3 to
0d31b53
Compare
ianthomas23
force-pushed
the
kernel-info-supported-debugger
branch
from
70767fa to
8298e05
Compare
|
|
||
| supported_features: list[str] = [] | ||
| if self._supports_kernel_subshells: | ||
| supported_features.append("kernel subshells") |
There was a problem hiding this comment.
Is it necessary to have "kernel", or could we just put "subshells"?
There was a problem hiding this comment.
"kernel subshells" is what is says in the JEP (https://github.com/jupyter/enhancement-proposals/blob/master/kernel-subshells/kernel-subshells.md#identify-optional-feature) so that is what it must be.
I don't understand, it seems that this PR does both add |
No, "kernel subshells" was already there but I've rearranged the code a little. |
|
Ah yes I see. |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 participants
JEP92 added support for optional features to be included in kernel info reply messages via the
supported_featuresattribute, with subshells and debugger being examples. We are already using it for subshells, this PR also addsdebuggerto the list ofsupported_featuresifdebugpyis importable.Corresponding documentation PR in
jupyter_clientfor messaging protocol is jupyter/jupyter_client#1045.This replaces the use of
kernel_info_reply['debugger']which should be considered deprecated but cannot be removed until downstream libraries adopt reading thesupported_featuresrather thandebuggerattribute directly.