Skip to content

socket must be None, not shell_socket for default shell #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
minrk merged 1 commit into from
Oct 22, 2024
Merged

socket must be None, not shell_socket for default shell #1281

minrk merged 1 commit into from
Oct 22, 2024

Conversation

@minrk
Copy link
Member

@minrk minrk commented Oct 22, 2024

process_shell_message has

assert socket is None

for the default subshell, so passing shell_socket here results in:

socket = self.shell_socket
...
assert socket is None
socket = self.shell_socket

@minrk minrk added the bug label Oct 22, 2024
@minrk minrk requested a review from ianthomas23 October 22, 2024 12:57
@minrk
Copy link
Member Author

minrk commented Oct 22, 2024

alternative change would be to update the assert to assert socket in {self.shell_socket, None}, but this seems to match other calls to shell_main

ianthomas23
ianthomas23 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minrk

@minrk minrk merged commit 2ca7992 into ipython:main Oct 22, 2024
@minrk minrk deleted the shell_socket_none branch October 22, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianthomas23 ianthomas23 ianthomas23 approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minrk @ianthomas23