fix: on exception, return a 0, so that the "sum" still computes #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where after a while in a Jupyter notebook, we start
to see many log lines like this:
```
[IPKernelApp] ERROR | Exception in control handler:
Traceback (most recent call last):
File ".../lib/python3.8/site-packages/ipykernel/kernelbase.py", line 336, in process_control
await result
File ".../lib/python3.8/site-packages/ipykernel/kernelbase.py", line 998, in usage_request
reply_content["kernel_memory"] = sum(
TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'
```
Since the "sum" expects a number (float or int) as elements given to the "sum",
we should pass "0" (zero) and not None when we that process id does not exist
anymore.
This was tested in an actually running notebook and it fixed the problem:
* no morre Exceptions like the one reported above
* correct memory stats where seen with the Kernel Usage plug-ins
Contributor
Author
|
This is a bug fix and needs the "bugfix" Label. As an external contributor, I am unable to set it. Also, I am pinging @echarles since we discussed this out-of-band and Eric is marked in git as the previous contributor that touched this code. Many thanks for your attention (I hacked it locally here in the site-packages and it seems to work for me :-) |
Member
|
@blink1073 📝 test_lint → ❌ failure [required to succeed] is failing, not sure about that one. |
Contributor
Author
|
There seems to be a problem with a linting ignore that is not correctly set-up ? |
Contributor
Author
|
FYI: the same "linting" problem also occurs in another PR I just made today (5 Feb 2024) and that only added 1 line to .gitignore: |
Contributor
|
The lint failures comes from a version update in the linter, I'll address in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where after a while in a Jupyter notebook, we start to see many log lines like this:
Since the "sum" expects a number (float or int) as elements given to the "sum", we should pass "0" (zero) and not None when that process id does not exist anymore.
This was tested in an actually running notebook and it fixed the problem: