docs: add paragraph describing HAMT fanout limit#507
Closed
achingbrain wants to merge 2 commits intomainfrom
Closed
docs: add paragraph describing HAMT fanout limit#507achingbrain wants to merge 2 commits intomainfrom
achingbrain wants to merge 2 commits intomainfrom
Conversation
I came across [this comment](https://github.com/ipfs/boxo/blob/364c5040ec91ec8e2a61446e9921e9225704c34d/ipld/unixfs/hamt/hamt.go#L778) in the boxo source code. It's worth documenting this constant so other implementations don't expose themselves to GHSA-q264-w97q-q778 accidentally.
🚀 Build Preview on IPFS ready
|
Member
Author
|
Looks like lots of bits of the spec fail the linter |
lidel
added a commit
to Jorropo/specs
that referenced
this pull request
Aug 23, 2025
incorporate CVE-2023-23625 vulnerability details from ipfs#507 - enforce maximum fanout of 1024 to prevent DoS attacks - add security warning with links to CVE and GHSA advisory
Member
|
Thank you @achingbrain! Boxo seems to already enforce limit of max 1024 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this comment in the boxo source code.
It's worth documenting this constant so other implementations don't expose themselves to GHSA-q264-w97q-q778 accidentally.
Refs: ipshipyard/roadmaps#16