Conversation
This comment was marked as outdated.
This comment was marked as outdated.
lidel
reviewed
Mar 21, 2023
663c99e to
ac2ba02
Compare
darobin
reviewed
Mar 27, 2023
Contributor
darobin
left a comment
There was a problem hiding this comment.
These are mostly questions and general comments, nothing on the critical path.
6aaafa9 to
8d24f99
Compare
Member
Author
|
I marked it as ready for review as I think most things are "ready". We just have to merge ipfs/spec-generator#6 and settle on how we want to style the IPIPs. |
7 tasks
e4fc117 to
630ed99
Compare
7faaf5c to
26a941c
Compare
4d82ff7 to
c264a3c
Compare
Member
Author
fbc1a53 to
94e0c46
Compare
Member
Author
|
@lidel not critical for our presentation, so we can push it back for next week. |
a765720 to
178c9f3
Compare
178c9f3 to
cce026c
Compare
4 tasks
cce026c to
8df7470
Compare
darobin
reviewed
May 5, 2023
| display: block; | ||
| background: url('/img/watermark-ratified.svg'); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Couldn't this use background-image on body? It would be less hacky.
darobin
approved these changes
May 5, 2023
Contributor
darobin
left a comment
There was a problem hiding this comment.
It would be nice to do the watermark differently, but I would rather ship now and fix later than hold up just for that.
Member
Author
|
@darobin i don't like the way I did the watermakrs either. Suggestions? |
e09e1b4 to
f8194ae
Compare
f8194ae to
9388d0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Based on #394.
A preview of what moving the IPIPs can look like. Nice things to get: