Closed
Conversation
hacdias
changed the title
hacdias
force-pushed
the
chore/lint-path-gateway
branch
from
afda5f5 to
d4025f3
Compare
SgtPooki
approved these changes
Sep 15, 2022
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
Can we modify the linter workflow so that these things are handled automatically in the future?
Member
Author
|
@SgtPooki we should. Right now, it seems the CI is only linting the files within the changed directory, giving the false impression that everything is fine when it isn't. That explains why the majority of the PRs are actually failing. Merging |
Member
Author
|
I spoke to @lidel and it seems that the linting will be improved soon, as well as the way we present our specs. I'm closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Procedure:
And some manual checks that are not automatically fixed by the linter.