Conversation
Contributor
hsanjuan
requested changes
Sep 25, 2025
Contributor
hsanjuan
left a comment
hsanjuan
left a comment
There was a problem hiding this comment.
This is setting a timeout for both the http.Client that makes requested to delegated routing endpoints, as well as the ParallelRouter.
Since we are introducing it, it's probably best to separate both timeout and have a RAINBOW_ROUTING_TIMEOUT next to RAINBOW_HTTP_ROUTERS_TIMEOUT.
Member
|
Triage note:
|
hsanjuan
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Summary
Implements configurable timeout for HTTP routing v1 client to prevent denial of service when routing responses take longer than the previously hardcoded 15 seconds.
Note: HTTP routing metrics were already implemented and working in the existing codebase this PR only adds the missing configurable timeout functionality.
Changes Made
✅ Configurable HTTP Client Timeout
✅ Verified Existing Metrics Work
Testing
Reviewer: @lidel and @hsanjuan