feat(config): AutoConf with "auto" placeholders#286
Merged
Conversation
depends on ipfs/boxo#997
lidel
changed the title
20 tasks
gammazero
approved these changes
Aug 14, 2025
Contributor
gammazero
left a comment
gammazero
left a comment
There was a problem hiding this comment.
Only trivial comments, otherwise good to merge.
align with boxo gateway default value
- reverts automatic dependency upgrade to keep PR focused - updates boxo to latest main with autoconf support
gammazero
approved these changes
Aug 15, 2025
Contributor
gammazero
left a comment
gammazero
left a comment
There was a problem hiding this comment.
One comment regarding pebble.
instead of silently stripping 'auto' values, now returns clear error messages indicating which config options need explicit values
- merge autoconf_routing_test.go into autoconf_test.go - add meaningful error messages to assertions - organize with subtests using t.Run()
Member
Author
|
@hsanjuan applied changes discussed during triage today:
take a look, if looks ok, feel free to merge |
Contributor
|
I have just moved the |
hsanjuan
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds AutoConf support to Rainbow.