chore: update boxo to version with fewer globals#9907
Merged
Conversation
aschmahmann
force-pushed
the
feat/boxo-update-fewer-globals
branch
2 times, most recently
from
73e1ef4 to
cfa056d
Compare
aschmahmann
commented
May 31, 2023
| return err | ||
| } | ||
|
|
||
| blockDecoder := ipldlegacy.NewDecoder() |
Contributor
Author
There was a problem hiding this comment.
The use a global here (i.e. the go-ipld-prime defaults) is pretty unfortunate and subtle. However, it should be ok.
Note: previously this decoder included the registration of the go-ipld-format Raw and Dag-Pb converters. However, IIUC that shouldn't be necessary in this function since the go-codec-dagpb codec and the built-in go-ipld-prime raw codec should be sufficient.
14 tasks
aschmahmann
force-pushed
the
feat/boxo-update-fewer-globals
branch
from
dbfb4e9 to
8e917b6
Compare
This was referenced Jun 7, 2023
aschmahmann
force-pushed
the
feat/boxo-update-fewer-globals
branch
2 times, most recently
from
670d307 to
624267d
Compare
Jorropo
reviewed
Jun 8, 2023
Contributor
Jorropo
left a comment
Jorropo
left a comment
There was a problem hiding this comment.
(Meta boxo comment) It is sad to see a consumer go through breaking changes update for what is a code we want to kill.
aschmahmann
force-pushed
the
feat/boxo-update-fewer-globals
branch
from
624267d to
4cde204
Compare
Contributor
Author
|
A couple notes:
|
…ers via go-ipld-legacy instead of go-ipld-format ones
Jorropo
force-pushed
the
feat/boxo-update-fewer-globals
branch
from
4cde204 to
5fbe8c6
Compare
Jorropo
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validating ipfs/boxo#324 which collects the changes to resolve ipfs/boxo#291