refactor(gw/dir-index-html): remove gobindata#8872
Merged
Conversation
Member
Author
|
@Jorropo will you have time to fix errors detected on CI? |
Jorropo
approved these changes
Apr 11, 2022
Contributor
|
@lidel I can tomorrow |
Contributor
Right - xxhash is now a dependency - I missed that. Ran |
Contributor
|
@lidel we actually use $ ipfs version deps | grep xxhash
github.com/cespare/[email protected]
github.com/cespare/xxhash/[email protected] |
Since go1.16, there are built in tools that allow for embeding filesystem inside the binary. We now make use of the `embed` package to have all files put into the binary, removing the need to generate the files and removes dependencies Co-authored-by: Jorropo <[email protected]>
This removes the delegation to the function and requires all callers that used the `asset.Asset` func to access to asset via the `embed.FS`
Jorropo
force-pushed
the
remove-go-bin-data
branch
from
201f4ce to
2a545c9
Compare
Contributor
|
I've also took the liberty to meaning fully squash thoses commits following atomic principles. |
Member
Author
|
@Jorropo next time just squash an entire cleanup like this into a single commit – less noise, more signal in https://github.com/ipfs/go-ipfs/commits/master 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is code by @ frankywahl from #8834 pushed as upstream branch just to fix Circle CI.