@marten-seemann Initial take on stats command to get some feedback before moving on with limit and then deciding where to place this API.

@marten-seemann

Were you able to test the command (actually running it)? Is it working as expected?

If the answer is yes I'll proceed to plumb the limit command.

After that, I'll need you to define in the original thread where exactly is this command going to live, and if it should have its own API in github.com/ipfs/interface-go-ipfs-core or will be processed directly by the command's logic. (Please discuss that there in the issue to leave this PR for implementation discussions if possible.)

Were you able to test the command (actually running it)? Is it working as expected?

Everything works as expected, except for the peer command. It either fails to parse a (valid) peer ID (e.g. Error: invalid peer ID: QmfCY8CGoFpyDZvKvBkGqoxsqzTDgG8VTAjKzBimJqY5UU: length greater than remaining number of bytes in buffer), or it reports all 0s for a peer.

length greater than remaining number of bytes in buffer

Yeah, it's doing that for the CIDv0 addresses (Qm...), not sure why, might be a deeper issue I'll need to look into later.

ipfs swarm stats peer:QmNWpN4P7nb81zyKHoSaPx4aWdAV9po4UTpjypvk4eA377 # Fails
ipfs swarm stats peer:12D3KooWSriosYwnx52vWPwPmGoLA1F1seBXCUf5UsMSMT1bpJpX # Works

or it reports all 0s for a peer.

I'm not seeing that in local test:

$ ipfs swarm stats all | jq

{
  "Peers": {
    "12D3KooWAta4KZHRYhZPZko6Nbt6sMMgWy9Mgm42dJLdxcBL6HtN": {
      "Memory": 8323,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 0,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 0
    },
    "12D3KooWB3FXPG1RAqgZuA5iDZymTCHBFD1vcwfY2cjPLJmq7udi": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 1
    },
    "12D3KooWB7LPTnH7kDjuDYF6A81RUQh3NXAN9tpFi2NzunVc3KC1": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 0,
      "NumStreamsInbound": 1,
      "NumStreamsOutbound": 1
    },
    "12D3KooWBBGfqDkVEddhq8j6prz3fDwbznB1j3TaS2dgpcTsa2xB": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 1
    },
    "12D3KooWBJhfKCkEa6jtohx2p3efqEYAfKkS43cqXHN196Ea3TAq": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 0,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 0
    },
    "12D3KooWBRLmSWB4c235i5Xy9afRm17hfGaxocU33F9fLcyhmA4s": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 1
    },
    "12D3KooWBV2BkQwD3vdMp46JdQxPi1nw9SLRTDBo5qdjy6oPpnvJ": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 0,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 0
    },
    "12D3KooWBYGH7TiHUeWtmxkQ7QV98ee6uHZkpahaVbFUyP7y316R": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 0,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 0
    },
    "12D3KooWBfjrvKUpxWaLFGjAWSLD3tav8CZ5mC2k3e6WRbM5rwrW": {
      "Memory": 3717,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 1,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 1
    },
    "12D3KooWBnSRDWYYJbuJ8PFr4Y2ehtJJHDN6trTnWuw2b8v8KjLN": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 0,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 0
    },
    "12D3KooWBuH48Zt5Nm2DAmhywaE6vMCutuiNqkYPAzYBmmyfm5cp": {
      "Memory": 0,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 0,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 1
    },
    "12D3KooWC11Cy9DjPYNQHApzTdSxLQixsenmB3JbFGSpcX4pVVyo": {
      "Memory": 5403,
      "NumConnsInbound": 0,
      "NumConnsOutbound": 1,
      "NumFD": 1,
      "NumStreamsInbound": 0,
      "NumStreamsOutbound": 1
    },

Sorry, I should've been more specific: the peer output in all works, it's when I query the peer scope directly that it's all 0s.

The decode might be the issue of peer.Decode vs peer.IDFromString (just a guess without digging into it).

The decode might be the issue of peer.Decode vs peer.IDFromString (just a guess without digging into it).

Yes, we're using the second, should we switch?

Sorry, I should've been more specific: the peer output in all works, it's when I query the peer scope directly that it's all 0s.

Confirmed, will look into it, though it's a pretty straightforward call to the library's ViewPeer so the issue might be upstream. Was this working in Lotus?

Confirmed, will look into it, though it's a pretty straightforward call to the library's ViewPeer so the issue might be upstream. Was this working in Lotus?

@vyzo, have you tried this?

@marten-seemann Mind giving the limit command a try?

Something like

ipfs swarm limit system > limit.json
# Modify JSON
ipfs swarm limit system -s limit.json

we dont have legacy peers in lotus so it worked all dandy when i tried it.
IDFromString should work here.

It should be Decode, not IDFromString. I fixed this PR, and now I'm able to query peer IDs.

@marten-seemann Mind giving the limit command a try?

Something like

ipfs swarm limit system > limit.json
# Modify JSON
ipfs swarm limit system -s limit.json

@schomatis I tried this, and it can't find the file:

❯ ipfs swarm limit system -s limit.json
Error: error opening limit JSON file: open limit.json: no such file or directory

@marten-seemann Did the read limit command

ipfs swarm limit system > limit.json

before

ipfs swarm limit system -s limit.json

not generate any output? Are you running both commands in the same CLI/daemon?

@schomatis It works now! Thank you!

Can you rebase this on top of the (updated) update-libp2p-v018 branch?

@marten-seemann Rebased. Left some TODOs in the PR description which I can't resolve myself.

Nothing more for me to do at the moment so I'll remove my assignment from this.

@marten-seemann is going to merge this into the update-libp2p-v018 branch once the tests in #8680 pass.

To be clear for anyone watching, this remaining work is now happening in #8680