Merged
Conversation
48 tasks
Contributor
|
@aschmahmann notes that for interfaces added to the We need to think about whether there's a sane way to plum the exposed interface over the http interface |
bc32dea to
0c4fa8f
Compare
12dff57 to
72d2c03
Compare
implement a node interface that provides direct access to go-ipld-prime tools License: MIT Signed-off-by: hannahhoward <[email protected]>
License: MIT Signed-off-by: hannahhoward <[email protected]>
Update to latest fetcher/dag-writer and fix node api License: MIT Signed-off-by: hannahhoward <[email protected]>
72d2c03 to
7f716a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Provide a direct interface to IPLD prime based tools for reading and writing DAGs
implement ipfs/interface-go-ipfs-core#68
Implementation
Implement the node API by just combining go-fetcher.FetcherConfig + go-dagwriter.DagWritingService
For Discussion
I went ahead and augmented the fetcher with unixfs functionality -- should we do this?