Conversation
url is localhost:port/#/explore/bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze based on latest hash from https://github.com/ipfs/distributed-wikipedia-mirror/blob/1aa50702fc6d8e2be106e37d4c68dc2ca5b94f20/snapshot-hashes.yml#LL13C10-L13C69
This reverts commit ca0a50b.
whizzzkid
left a comment
There was a problem hiding this comment.
first pass looks good, any meaningful way to break this dowm?
| import 'react-virtualized/styles.css' | ||
| import { composeBundles, createRouteBundle } from 'redux-bundler' | ||
| import { Provider as ReduxStoreProvider, connect } from 'redux-bundler-react' | ||
| import 'tachyons' |
There was a problem hiding this comment.
can we sort/organize imports across?
There was a problem hiding this comment.
i'm not sure what that means. see .eslintrc.js 'import/order'.groups
| error: null | ||
| } | ||
|
|
||
| function getUserOpts (key: string): Record<string, unknown> { |
There was a problem hiding this comment.
Cause it can be anything.. it's localStorage
| <div className='red fw2 ma0 f7'>{cidErr.message}</div> | ||
| </div> | ||
| )} | ||
| )} |
There was a problem hiding this comment.
it's using standard style for formatting, so it should be correct. build runs lint which runs standard, so it would fail if it werent correct.
There was a problem hiding this comment.
this is already a pretty large change, I'm trying not to modify any of the horrendous jsx or ternary statements that already existed before I got here. we can do a pass later
whizzzkid
left a comment
There was a problem hiding this comment.
LGTM in principle, not seeing any major ⛳️
When will this PR be removed from Draft/WIP?
bafyreicnokmhmrnlp2wjhyk2haep4tqxiptwfrp2rrs7rzq7uk766chqvq/cheese/0path, currently showingError: Requested IPLD path should end with the remainder patherrorThis PR was mainly intended to address #359, but in the process, we were able to solve a number of longstanding issues.
Preview of these changes in explore.ipld.io are available at https://bafybeici5vqsnnrggriwslm5m6ztoyedcumk2imy62ywwjficn5qt6fw6u.on.fleek.co/
This PR has the following changes:
src/lib/get-raw-block.ts(seeipld-explorer-components/src/lib/get-raw-block.ts
Line 105 in 75461c2
fixes #359
fixes #279
fixes #311
fixes #335
fixes #355
This is a large win for work required from ipfs/ipfs-webui#1965
related to explore.ipld.io changes at ipld/explore.ipld.io#119
Demo Video:
explore.ipld.io-2023-05-25-update.mp4