Closed
Conversation
SgtPooki
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Feb 10, 2023
SgtPooki
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Feb 10, 2023
2 tasks
SgtPooki
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Feb 16, 2023
not needed once ipfs/ipld-explorer-components#356 is merged
whizzzkid
approved these changes
Feb 17, 2023
Contributor
whizzzkid
left a comment
whizzzkid
left a comment
There was a problem hiding this comment.
nits, but not blockers.
Comment on lines
195
to
201
| const formats = formatImports.map((actualModule) => { | ||
| if (actualModule.util == null) { | ||
| // actualModule has no util. using blockcodec-to-ipld-format | ||
| return convert(actualModule) | ||
| } | ||
| return actualModule | ||
| }) |
Contributor
There was a problem hiding this comment.
can this convert method handle if util exists or not?
Member
Author
There was a problem hiding this comment.
it cannot, unfortunately. though it probably should do some assertion on the format and return untouched if it matches the expected format.
Member
Author
There was a problem hiding this comment.
whizzzkid
requested changes
Feb 23, 2023
Contributor
whizzzkid
left a comment
whizzzkid
left a comment
There was a problem hiding this comment.
For consistency and lack of TS
| * * https://github.com/ipld/js-blockcodec-to-ipld-format/blob/master/src/index.js#L38-L55 | ||
| */ | ||
| options.resolve = (buf, path = '') => { | ||
| let value = actualModule.decode(buf) |
Contributor
There was a problem hiding this comment.
ugh, JS, does this need to be awaited?
Member
Author
There was a problem hiding this comment.
I don't believe so based on the modules i've seen
SgtPooki
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Mar 13, 2023
* feat!: ipfs-http-client -> kubo-rpc-client fix: error rendering peerId fix: peers table on peerspage fix: statusPage -> advanced -> addresses fix: most e2e tests working with kubo-rpc-client chore: update to go-ipfsv0.18.1 * chore: fix key.gen with patch needed until kubo-rpc-client fix is merged see ipfs/js-kubo-rpc-client#143 see ipfs/js-kubo-rpc-client#145 * fix: use ipld-explorer-components patch temporarily see https://github.com/ipfs/ipfs-webui/issues/2079\#issuecomment-1426219633 see #2079 (comment) must use until ipfs/ipld-explorer-components#356 * chore: fix ipld-explorer-components patch not needed once ipfs/ipld-explorer-components#356 is merged * test: add tests to explore.test.js * tmp: trying to navigate the undocumented world of parsing CIDs * chore: working on getting tests fully tied up * test(e2e): finish updating explore.test.js * chore: lint fixes * chore: remove debugging code * test: test clicking children links on explore page * tmp: fix children explore views * test: e2e explore test traverses children * Update test/e2e/explore.test.js Co-authored-by: Nishant Arora <[email protected]> * chore: address PR comments --------- Co-authored-by: Nishant Arora <[email protected]>
Co-authored-by: Nishant Arora <[email protected]>
Member
Author
|
closing this because #360 removes the need for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues seen when using ipld-explorer-components in webui with kubo-rpc-client
see comments in ipfs/ipfs-webui#2079 for details