fix: avoid double-encode for extension size estimation#340
Merged
rvagg merged 1 commit intorvagg/uuid-rebasingfrom Feb 4, 2022
Merged
fix: avoid double-encode for extension size estimation#340rvagg merged 1 commit intorvagg/uuid-rebasingfrom
rvagg merged 1 commit intorvagg/uuid-rebasingfrom
Conversation
rvagg
force-pushed
the
rvagg/dagcbor-extension-sizing
branch
from
11365fc to
5cfe399
Compare
hannahhoward
approved these changes
Feb 2, 2022
Collaborator
hannahhoward
left a comment
hannahhoward
left a comment
There was a problem hiding this comment.
LGTM. Seems reasonable for now unless we encounter performance issues.
rvagg
force-pushed
the
rvagg/dagcbor-extension-sizing
branch
from
5cfe399 to
4d4c76e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is draft pending merging of ipld/go-ipld-prime#346