Conversation
Jorropo
added a commit
to ipfs/boxo
that referenced
this pull request
Jun 12, 2023
```
$ benchstat /mnt/ramdisk/{old,new}
name old time/op new time/op delta
PB-12 730ns ± 5% 255ns ± 2% -65.04% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
PB-12 224B ± 0% 0B -100.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
PB-12 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
```
Depends on ipfs/go-cid#159.
Jorropo
added a commit
to ipfs/boxo
that referenced
this pull request
Jun 12, 2023
```
$ benchstat /mnt/ramdisk/{old,new}
name old time/op new time/op delta
PB-12 730ns ± 5% 255ns ± 2% -65.04% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
PB-12 224B ± 0% 0B -100.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
PB-12 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
```
Depends on ipfs/go-cid#159.
Jorropo
added a commit
to ipfs/boxo
that referenced
this pull request
Jun 12, 2023
```
$ benchstat /mnt/ramdisk/{old,new}
name old time/op new time/op delta
PB-12 730ns ± 5% 255ns ± 2% -65.04% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
PB-12 224B ± 0% 0B -100.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
PB-12 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
```
Depends on ipfs/go-cid#159.
willscott
reviewed
Jun 12, 2023
willscott
left a comment
willscott
left a comment
There was a problem hiding this comment.
- We probably should have the cid test and fuzzing also run against GenericCid
- would be good to add a test demonstrating that a cid with a backing []byte can interop with a string cid.
4 tasks
Jorropo
added a commit
to ipfs/boxo
that referenced
this pull request
Jun 12, 2023
```
$ benchstat /mnt/ramdisk/{old,new}
name old time/op new time/op delta
PB-12 730ns ± 5% 255ns ± 2% -65.04% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
PB-12 224B ± 0% 0B -100.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
PB-12 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
```
Depends on ipfs/go-cid#159.
Jorropo
added a commit
to ipfs/boxo
that referenced
this pull request
Jun 12, 2023
```
$ benchstat /mnt/ramdisk/{old,new}
name old time/op new time/op delta
PB-12 730ns ± 5% 255ns ± 2% -65.04% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
PB-12 224B ± 0% 0B -100.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
PB-12 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
```
Depends on ipfs/go-cid#159.
This skips an allocation when appending strings to bytes.
Contributor
|
Imho this is valuable and should be revisited. Code is still available at https://github.com/ipfs/go-cid/compare/468cca0d172b911fa0a8a0f59ba087682531fea6 |
Member
|
@MichaelMure feel free to take it over and try again with a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is backward compatible (that why I hacked it with generics).
I should probably make generic versions of the builders too.
Results: