Conversation
The goal is to stop doing two allocations for each block (now it will only allocate the []byte buffer, and pass the cid.Cid, []byte pair by decomposed registers or stack). This way of changing does not change the syntax for trivial uses of block.Block, so in theory we will have to update only producers of block.Block, not consumers. Fixes #45 Replaces ipfs/boxo#192 Note: This change will cause a failure here: https://github.com/ipfs/go-ipld-format/blob/0f7aff00f72e9dea0d9718bc0972e309ba7c3e8d/format.go#L27
gammazero
force-pushed
the
feat/value-block
branch
from
be42814 to
e82c533
Compare
|
This requires many changes in boxo, which passes a There are other places where more functionality is added to a block, or where something like an IPLD Node can be treated as a block, and a Removing the This PR is good for the purpose of forcing |
|
Triage notes:
|
|
Triage notes:
|
|
Recommend closing this PR, See explanation. |
|
Triage notes:
|
3 participants
The goal is to stop doing two allocations for each block (now it will only allocate the
[]bytebuffer, and pass thecid.Cid,[]bytepair by decomposed registers or stack).This way of changing does not change the syntax for trivial uses of
block.Block, so in theory we will have to update only producers ofblock.Block, not consumers.Fixes #45
Replaces ipfs/boxo#192
Note: This change will cause a failure here:
https://github.com/ipfs/go-ipld-format/blob/0f7aff00f72e9dea0d9718bc0972e309ba7c3e8d/format.go#L27