This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Merged
Conversation
Jorropo
force-pushed
the
split
branch
2 times, most recently
from
5bb5742 to
9a2d8ea
Compare
Contributor
Author
|
"it works on my machine" (I hate race conditions) Maybe I should try rebasing this on some of your race fixing @guseggert ? |
This test is exceptionally racy and IMO useless (you can go read the 10 lines of code making up tracing and convaince yourself it's working.)
guseggert
suggested changes
Aug 8, 2022
Contributor
|
Can't comment on renamed files, but shouldn't we leave /docs in the root dir instead of moving to /client/docs ? |
Contributor
Author
Yeah I'll fix. |
guseggert
force-pushed
the
split
branch
2 times, most recently
from
1d83ac2 to
0efd31d
Compare
guseggert
approved these changes
Aug 13, 2022
Contributor
|
Side note: on Windows and Mac, the |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
feat: split client and server This commit was moved from ipfs/go-bitswap@5b013e0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Closes #568