This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Merged
Conversation
Stebalien
suggested changes
Mar 13, 2020
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
I'm a bit concerned about the performance hit. While these debug log statements won't actually do anything under the covers, we'll still have to allocate, copy, and iterate more than we should.
Stebalien
approved these changes
Mar 16, 2020
Closed
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
Clean up logs This commit was moved from ipfs/go-bitswap@bced0f3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.