bitswap/httpnet: start pinging before signaling Connected#982
Merged
Conversation
Assuming that the stack might get a Connected notification, but we have not yet started pinging. Attempting to send a message at that moment fails, the messagequeue shutdown as a result, but no disconnect/connect happens from that point as it expects. Also add some logging to see if we are hitting those message sender exists.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #982 +/- ##
=======================================
Coverage 61.52% 61.53%
=======================================
Files 254 254
Lines 31490 31491 +1
=======================================
+ Hits 19375 19378 +3
Misses 10526 10526
+ Partials 1589 1587 -2
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gammazero
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming that the stack might get a Connected notification, but we have not yet started pinging.
Attempting to send a message at that moment fails, the messagequeue shutdown as a result, but no disconnect/connect happens from that point as it expects.
Also add some logging to see if we are hitting those message sender exists.