Merged
Conversation
quality of life fix that avoids silent errors like one described in ipfs/kubo#10853
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 61.51% 61.55% +0.04%
==========================================
Files 254 254
Lines 31400 31420 +20
==========================================
+ Hits 19316 19342 +26
+ Misses 10507 10500 -7
- Partials 1577 1578 +1
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gammazero
approved these changes
Jul 7, 2025
Contributor
gammazero
left a comment
gammazero
left a comment
There was a problem hiding this comment.
Looks good, comment about test.
Comment on lines
+734
to
+742
| t.Run(c.name, func(t *testing.T) { | ||
| result, err := normalizeBaseURL(c.input) | ||
| if c.expectError { | ||
| require.Error(t, err) | ||
| assert.Contains(t, err.Error(), "only /routing/v1 URLs are supported") | ||
| } else { | ||
| require.NoError(t, err) | ||
| assert.Equal(t, c.expected, result) | ||
| } |
Contributor
There was a problem hiding this comment.
Calling New calls normalizeBaseURL, so is the above part of the test still needed?
Member
Author
There was a problem hiding this comment.
yes, just me being paranoid (a precaution in case New gets refactored to not call it)
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jul 8, 2025
this wires up ipfs/boxo#971 to make sure explicitly allowlisted hosts have their own metric label if we ever need more flexibility here, this can be exposed as a separate config
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jul 8, 2025
this wires up ipfs/boxo#971 to make sure explicitly allowlisted hosts have their own metric label if we ever need more flexibility here, this can be exposed as a separate config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality of life fix that avoids silent errors like one described in ipfs/kubo#10853